test: unskip sm-core integ tests#5856
Open
lucasjia-aws wants to merge 8 commits into
Open
Conversation
lucasjia-aws
force-pushed
the
unskip-integ-tests-core
branch
from
4147d4a to
076b890
Compare
lucasjia-aws
force-pushed
the
unskip-integ-tests-core
branch
from
67d18ca to
24fcdac
Compare
lucasjia-aws
force-pushed
the
unskip-integ-tests-core
branch
from
24fcdac to
b17f7b7
Compare
lucasjia-aws
force-pushed
the
unskip-integ-tests-core
branch
from
c8108c7 to
6aa560b
Compare
…ineffective locals() assignment with args dict
…ced_job_setting - Add tests/integ/kms_utils.py with get_or_create_kms_key utility ported from SageMakerHulkPythonSDK, adapted for sagemaker-core import paths - Uncomment kms_utils import in test_decorator.py to fix NameError in s3_kms_key fixture
… fix test bugs
- Add skipif for Python versions without Spark image (only 3.9/3.12 supported)
- Fix Properties set literal to dict: {"spark.app.name": "remote-spark-test"}
- Fix spark.conf.get() to use string key instead of attribute reference
lucasjia-aws
force-pushed
the
unskip-integ-tests-core
branch
from
6aa560b to
ff810ee
Compare
…hub schema additions" This reverts commit 1e12c52.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR audits and unskips integration tests in
sagemaker-coreas part of COE AI4 (skipped test audit). Each previously-skipped test was investigated for necessity, root cause of skip, and fixed where possible.Summary of Changes
test_retrieve_image_uri_intelligent_default28c168e3,533f3c6a,b17f7b7fImageRetriever: (1) replaced ineffectivelocals()assignment withargsdict, (2) added missingPYTHON_SDKin config path, (3) used PascalCase (_to_pascal_case) for config key lookup. Updated expected image version from 3.0.0 to 3.2.0.test_advanced_job_settinga1e0e17ekms_utils.pyfrom SageMakerHulkPythonSDK withget_or_create_kms_keyutility, adapted for sagemaker-core import paths. Uncommented the import in test file.test_decorator_with_spark_job6aa560bc@pytest.mark.skipiffor Python != 3.9 or 3.12 -- SageMaker Spark image only available for Python 3.9 and 3.12test_decorator_auto_capture5a914837Tests that remain skipped (with justification)
test_decorator_with_spark_jobsagemaker-spark-processing:3.3-cpu-py39-v1) does not have a workingpipin PATH. SDK auto-injectspip install sagemaker-feature-store-pysparkas a pre-exec command which fails. Requires Spark container image update. Conditionally skipped with@pytest.mark.skipifso it auto-enables when run on py39 with a fixed container.Testing
sagemaker-coreinteg test suite via CodeBuildtest_decorator_with_spark_jobon py39 and py312 to confirm root causetest_advanced_job_setting